At Tue, 22 Apr 2008 14:14:39 +0100,
Mark Brown wrote:
>
> From: Tim Niemeyer <tim.niemeyer@xxxxxxxxxxxxxx>
>
> Add some debug messages for suspend/resume and to add a clear prefix to
> s3c24xx-i2s and s3c24xx-pcm.
>
> Signed-off-by: Tim Niemeyer <reddog@xxxxxxxxxxxxxx>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Got the following checkpatch warnings. Please fix.
WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#17: FILE: soc/s3c24xx/s3c24xx-i2s.c:418:
+ DBG("Entered %s\n", __FUNCTION__);
WARNING: __func__ should be used instead of gcc specific __FUNCTION__
#25: FILE: soc/s3c24xx/s3c24xx-i2s.c:432:
+ DBG("Entered %s\n", __FUNCTION__);
thanks,
Takashi
> ---
> sound/soc/s3c24xx/s3c24xx-i2s.c | 4 +++-
> sound/soc/s3c24xx/s3c24xx-pcm.c | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/s3c24xx/s3c24xx-i2s.c b/sound/soc/s3c24xx/s3c24xx-i2s.c
> index 6b3cbbf..b7eca98 100644
> --- a/sound/soc/s3c24xx/s3c24xx-i2s.c
> +++ b/sound/soc/s3c24xx/s3c24xx-i2s.c
> @@ -46,7 +46,7 @@
>
> #define S3C24XX_I2S_DEBUG 0
> #if S3C24XX_I2S_DEBUG
> -#define DBG(x...) printk(KERN_DEBUG x)
> +#define DBG(x...) printk(KERN_DEBUG "s3c24xx-i2s: " x)
> #else
> #define DBG(x...)
> #endif
> @@ -415,6 +415,7 @@ static int s3c24xx_i2s_probe(struct platform_device *pdev)
> int s3c24xx_i2s_suspend(struct platform_device *pdev,
> struct snd_soc_cpu_dai *cpu_dai)
> {
> + DBG("Entered %s\n", __FUNCTION__);
> s3c24xx_i2s.iiscon = readl(s3c24xx_i2s.regs + S3C2410_IISCON);
> s3c24xx_i2s.iismod = readl(s3c24xx_i2s.regs + S3C2410_IISMOD);
> s3c24xx_i2s.iisfcon = readl(s3c24xx_i2s.regs + S3C2410_IISFCON);
> @@ -428,6 +429,7 @@ int s3c24xx_i2s_suspend(struct platform_device *pdev,
> int s3c24xx_i2s_resume(struct platform_device *pdev,
> struct snd_soc_cpu_dai *cpu_dai)
> {
> + DBG("Entered %s\n", __FUNCTION__);
> clk_enable(s3c24xx_i2s.iis_clk);
>
> writel(s3c24xx_i2s.iiscon, s3c24xx_i2s.regs + S3C2410_IISCON);
> diff --git a/sound/soc/s3c24xx/s3c24xx-pcm.c b/sound/soc/s3c24xx/s3c24xx-pcm.c
> index 29a6c82..5394a40 100644
> --- a/sound/soc/s3c24xx/s3c24xx-pcm.c
> +++ b/sound/soc/s3c24xx/s3c24xx-pcm.c
> @@ -39,7 +39,7 @@
>
> #define S3C24XX_PCM_DEBUG 0
> #if S3C24XX_PCM_DEBUG
> -#define DBG(x...) printk(KERN_DEBUG x)
> +#define DBG(x...) printk(KERN_DEBUG "s3c24xx-pcm: " x)
> #else
> #define DBG(x...)
> #endif
> --
> 1.5.5
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
