>>> +int avs_dsp_core_disable(struct avs_dev *adev, u32 core_mask) >>> +{ >>> + /* Be permissive to allow for full DSP shutdown in disable path. */ >> >> that comment isn't very clear, what is permissive here? > > > There is no error checking below. > >>> + avs_dsp_op(adev, stall, core_mask, true); >>> + avs_dsp_op(adev, reset, core_mask, true); >>> + >>> + return avs_dsp_op(adev, power, core_mask, false); consider adding a comment then, along the lines of 'we don't prevent suspend or shutdown with error checks' or something. 'permissive' was rather unclear to me.