On 2/24/22 12:04 AM, kernel test robot wrote: > Hi Vijendar, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on broonie-sound/for-next] > [also build test WARNING on v5.17-rc5 next-20220222] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit-scm.com%2Fdocs%2Fgit-format-patch&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=tOnbpasVg9EKIUUSTSE9EnqOdVFnodqU9BSzRO%2FBa5w%3D&reserved=0] > > url: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommits%2FVijendar-Mukunda%2FASoC-amd-vg-fix-for-pm-resume-callback-sequence%2F20220223-152636&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=by5tZtZsWgFaNQJHqido5zIm1Tg8O8y%2B68j0C%2BOmUb8%3D&reserved=0 > base: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fbroonie%2Fsound.git&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=k%2FF9xSFs3Fac1KgZZv90CEnJBqcXcjJDybN%2Bqr%2BZwwk%3D&reserved=0 for-next > config: x86_64-randconfig-a014 (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdownload.01.org%2F0day-ci%2Farchive%2F20220224%2F202202240237.RkL3TEe3-lkp%40intel.com%2Fconfig&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=krN1Mcd%2FibIB8NRSE04gaJz16jeZw1w73IDF0okDXz8%3D&reserved=0) > compiler: clang version 15.0.0 (https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=zwlf3eJdzR8Dvq5ASaL0Z52iBKdZoSYlA6sFsGFCYPc%3D&reserved=0 d271fc04d5b97b12e6b797c6067d3c96a8d7470e) > reproduce (this is a W=1 build): > wget https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=lvpnbsE%2BZ3BXnAPPlExpMlIhW5%2FQ0P%2FExu%2FPCiVjwM4%3D&reserved=0 -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux%2Fcommit%2F43c5f728cf59371b29569d941fb2ef2bdc3a279d&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=e3LH9P7U2tUfWkkKbJlK%2B%2BH4cWI0gb8%2FMaPAoH8K1Ek%3D&reserved=0 > git remote add linux-review https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2F0day-ci%2Flinux&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=g3SHzCHLx%2FcKKgHT0dXL3eX4%2BghrUVsboYstFOsMyPE%3D&reserved=0 > git fetch --no-tags linux-review Vijendar-Mukunda/ASoC-amd-vg-fix-for-pm-resume-callback-sequence/20220223-152636 > git checkout 43c5f728cf59371b29569d941fb2ef2bdc3a279d > # save the config file to linux build tree > mkdir build_dir > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/soc/amd/vangogh/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > >>> sound/soc/amd/vangogh/acp5x-pcm-dma.c:430:20: warning: variable 'frmt_val' set but not used [-Wunused-but-set-variable] > u32 val, reg_val, frmt_val; > ^ >>> sound/soc/amd/vangogh/acp5x-pcm-dma.c:430:11: warning: variable 'reg_val' set but not used [-Wunused-but-set-variable] > u32 val, reg_val, frmt_val; > ^ > 2 warnings generated. > will fix it and post the patch. > > vim +/frmt_val +430 sound/soc/amd/vangogh/acp5x-pcm-dma.c > > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 425 > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 426 static int __maybe_unused acp5x_pcm_resume(struct device *dev) > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 427 { > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 428 struct i2s_dev_data *adata; > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 429 struct i2s_stream_instance *rtd; > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 @430 u32 val, reg_val, frmt_val; > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 431 > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 432 reg_val = 0; > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 433 frmt_val = 0; > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 434 adata = dev_get_drvdata(dev); > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 435 > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 436 if (adata->play_stream && adata->play_stream->runtime) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 437 rtd = adata->play_stream->runtime->private_data; > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 438 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_PLAYBACK); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 439 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_HSTDM_ITER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 440 if (adata->tdm_mode == TDM_ENABLE) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 441 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_HSTDM_TXFRMT); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 442 val = acp_readl(adata->acp5x_base + ACP_HSTDM_ITER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 443 acp_writel(val | 0x2, adata->acp5x_base + ACP_HSTDM_ITER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 444 } > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 445 } > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 446 if (adata->i2ssp_play_stream && adata->i2ssp_play_stream->runtime) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 447 rtd = adata->i2ssp_play_stream->runtime->private_data; > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 448 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_PLAYBACK); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 449 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_I2STDM_ITER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 450 if (adata->tdm_mode == TDM_ENABLE) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 451 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_I2STDM_TXFRMT); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 452 val = acp_readl(adata->acp5x_base + ACP_I2STDM_ITER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 453 acp_writel(val | 0x2, adata->acp5x_base + ACP_I2STDM_ITER); > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 454 } > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 455 } > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 456 > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 457 if (adata->capture_stream && adata->capture_stream->runtime) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 458 rtd = adata->capture_stream->runtime->private_data; > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 459 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_CAPTURE); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 460 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_HSTDM_IRER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 461 if (adata->tdm_mode == TDM_ENABLE) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 462 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_HSTDM_RXFRMT); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 463 val = acp_readl(adata->acp5x_base + ACP_HSTDM_IRER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 464 acp_writel(val | 0x2, adata->acp5x_base + ACP_HSTDM_IRER); > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 465 } > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 466 } > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 467 if (adata->i2ssp_capture_stream && adata->i2ssp_capture_stream->runtime) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 468 rtd = adata->i2ssp_capture_stream->runtime->private_data; > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 469 config_acp5x_dma(rtd, SNDRV_PCM_STREAM_CAPTURE); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 470 acp_writel((rtd->xfer_resolution << 3), rtd->acp5x_base + ACP_I2STDM_IRER); > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 471 if (adata->tdm_mode == TDM_ENABLE) { > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 472 acp_writel(adata->tdm_fmt, adata->acp5x_base + ACP_I2STDM_RXFRMT); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 473 val = acp_readl(adata->acp5x_base + ACP_I2STDM_IRER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 474 acp_writel(val | 0x2, adata->acp5x_base + ACP_I2STDM_IRER); > 43c5f728cf5937 Vijendar Mukunda 2022-02-23 475 } > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 476 } > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 477 acp_writel(1, adata->acp5x_base + ACP_EXTERNAL_INTR_ENB); > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 478 return 0; > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 479 } > 361414dc1f07b7 Vijendar Mukunda 2021-07-21 480 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fhyperkitty%2Flist%2Fkbuild-all%40lists.01.org&data=04%7C01%7CVijendar.Mukunda%40amd.com%7Cc74e88a43d8949965f6208d9f6fb2b64%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637812380936350652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1hoLSE%2FHFOWzCDQLh174RuY5n6EZ7lnHu%2B0bSXoZUAA%3D&reserved=0
