Em Fri, 18 Feb 2022 12:11:59 -0600 Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> escreveu: > On 2/18/22 08:28, Mark Brown wrote: > > On Fri, 24 Dec 2021 14:09:48 +0100, Mauro Carvalho Chehab wrote: > >> Based on my tests, Huawei D15 (Intel) uses SSP0 on es8336. > >> > >> Add a quirk for it. > >> > >> Please notice that, currently, only the internal speaker is working. > >> The topology for the internal microphone and for the headphones > >> is wrong. Enabling/disabling the other two quirks (GPIO and/or DMIC) > >> doesn't cause any audible results, nor change the devices listed > >> on pavucontrol (tested with pipewire-pulse). > >> > >> [...] > > > > Applied to > > > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > > > Thanks! > > > > [1/1] ASoC: Intel: sof_es8336: add quirk for Huawei D15 2021 > > commit: ce6a70bfce21bb4edb7c0f29ecfb0522fa34ab71 > > I'll probably revert this change in my next update [1], I have a set of > changes where we can detect which SSP is used by parsing the NHTL > information in platform firmware. Mark, Yeah, I tested Pierre-Louis pull request from: https://github.com/thesofproject/linux/pull/3338 and indeed this quirk is not needed anymore for the speaker to work. So, once his new update gets merged upstream, feel free to revert this one. Pierre-Louis, When you submit your next update from PR#3338, feel free to add: Tested-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> and my Acked-by at the revert patch: Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > > I am still trying to figure out how to detect which MCLK is used, and > once this is done I'll send the patches upstream. > > [1] https://github.com/thesofproject/linux/pull/3338 Thanks, Mauro