回复:[PATCH -next] ASoC: codec: wcd938x: Fix NULL but dereferenced coccicheck error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It's okay for me,thanks.
------------------------------------------------------------------
发件人:Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx>
发送时间:2022年2月16日(星期三) 19:34
收件人:Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>; perex <perex@xxxxxxxx>
抄 送:tiwai <tiwai@xxxxxxxx>; lgirdwood <lgirdwood@xxxxxxxxx>; broonie <broonie@xxxxxxxxxx>; alsa-devel <alsa-devel@xxxxxxxxxxxxxxxx>; linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
主 题:Re: [PATCH -next] ASoC: codec: wcd938x: Fix NULL but dereferenced coccicheck error


On 2/16/2022 7:41 AM, Yang Li wrote:
Thanks for Fix Yang!!!
We are going to post complete cleaned patch. Shall we ignore this patch 
for now?
> Eliminate the following coccicheck warning:
> ./sound/soc/codecs/wcd938x.c:4210:21-24: ERROR: component is NULL but
> dereferenced.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Fixes: 013cc2aea0f6 ("ASoC: codec: wcd938x: Add switch control for selecting CTIA/OMTP Headset")
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> ---
>   sound/soc/codecs/wcd938x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c
> index 2663fe0bf64f..c46c4bfd84f2 100644
> --- a/sound/soc/codecs/wcd938x.c
> +++ b/sound/soc/codecs/wcd938x.c
> @@ -4207,7 +4207,7 @@ static bool wcd938x_swap_gnd_mic(struct snd_soc_component *component, bool activ
>    struct wcd938x_priv *wcd938x;
>   
>    if (!component) {
> -  dev_err(component->dev, "%s component is NULL\n", __func__);
> +  pr_err("The snd_soc_component is NULL\n");
>     return false;
>    }
>   





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux