On Tue, Feb 08, 2022 at 02:17:27PM +0200, Viorel Suman (OSS) wrote: > From: Viorel Suman <viorel.suman@xxxxxxx> > > On BIAS STANDBY->OFF transition the current implementation sleeps > 600ms on suspend in order to discharge the chip. The suspend is > propagated from "snd_soc_suspend" call for all audio cards in a > serial fashion, thus in case of boards like i.MX8DXL EVK which has > 3 distinct WM8960 codecs the total cumulated sleep on suspend is 1.8 > seconds. > > On the other hand the BIAS OFF->STANDBY transition happens > asynchronously with regard to "snd_soc_resume" - the call is > propagated from "soc_resume_deferred" which is just scheduled > from "snd_soc_resume", each card having its own work scheduled to > execute "soc_resume_deferred" call. > > The patch performs discharge completion on BIAS OFF->STANDBY transition > so that the cumulated effect on suspend described above is avoided > and discharge is completed in paralel in case of multiple WM8960 > codecs on the board. > > Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx> > --- Apologies Mark not sure how I missed this one, a bit late now, but the change looks good to me. Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> Thanks, Charles
