On 10/02/2022 16:41, Péter Ujfalusi wrote: > > > On 10/02/2022 15:54, Mark Brown wrote: >> On Thu, Feb 10, 2022 at 12:55:19PM +0200, Peter Ujfalusi wrote: >>> Add a new client driver for probes support and move >>> all the probes-related code from the core to the >>> client driver. >> >> This breaks an x86 allmodconfig build: >> >> /mnt/kernel/sound/soc/sof/compress.c: In function 'create_page_table': >> /mnt/kernel/sound/soc/sof/compress.c:87:9: error: implicit declaration of function 'snd_sof_create_page_table'; did you mean 'create_page_table'? [-Werror=implicit-function-declaration] >> 87 | return snd_sof_create_page_table(component->dev, dmab, >> | ^~~~~~~~~~~~~~~~~~~~~~~~~ >> | create_page_table > > Interesting, we have this under constant builds for months and we > certainly are building things as modules. > > Let me check and fix this. This patch never got reviewed in SOF: ASoC: SOF: compr: Add compress ops implementation and this introduced the use of snd_sof_create_page_table() I don't sof-compress enabled, only imx and mediatek have it enabled. Daniel, were there any reason to not send this to sof-dev prior? -- Péter
