On Thu, Feb 03, 2022 at 10:05:22AM +0000, Charles Keepax wrote: > > config SND_SOC_CS47L15 > > tristate > > + select REGMAP_IRQ > Would it be better to have depends on MFD_CS47L15 instead, > that way the other dependencies would be covered as well? I think > these were added before implies was a thing, and thus > dependencies didn't matter, since they could only be selected > which ignored deps anyway. It doesn't actually have a dependency at the ASoC level so it doesn't super matter. Given that it's this driver that's using the IRQ controller it needs the select it would probably be better to have that set up in the MFD anyway. > I would expect L35, L85, L90, L92 to be affected as well. Happy > to do a patch to fix this up, if you prefer? I don't mind either way, it's not causing problems to have the dependency missing.
Attachment:
signature.asc
Description: PGP signature
