Hi Stefan, On 1/21/22 18:24, Stefan Binding wrote: > Add support for SPI bus in the i2c-multi-instantiate driver as > upcoming laptops will need to multi instantiate SPI devices from > a single device node, which has multiple SpiSerialBus entries at > the ACPI table. > > With the new SPI support, i2c-multi-instantiate becomes > bus-multi-instantiate and is moved to the ACPI folder. > > The intention is to support the SPI bus by re-using the current > I2C multi instantiate, instead of creating a new SPI multi > instantiate, to make it possible for peripherals that can be > controlled by I2C or SPI to have the same HID at the ACPI table. > > The new driver (serial multi instantiate, smi) checks for the > hard-coded bus type and returns -ENODEV in case of zero devices > found for that bus. In the case of automatic bus detection, > the driver will give preference to I2C. > > The expectation is for a device node in the ACPI table to have > multiple I2cSerialBus only or multiple SpiSerialBus only, not > a mix of both; and for the case where there are both entries in > one device node, only the I2C ones would be probed. > > This new serial multi instantiate will be used in CS35L41 HDA new > driver. > > Changes since V5: > - comment, commit message and Kconfig description fixes > - minor fixes in serial-multi-instantiate > - use lowercase for SSIDs in patch_realtek.c Thank you for the new versions. I gave a bunch of: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> tags for v4, unless you make big changes, you are supposed to collect this tag and add it to newer versions of the patch-set (just above your own S-o-b). I'll resend the Reviewed-by-s for this version, please collect them for the next version (I noticed there are still some small issues, sorry). Regards, Hans > > Lucas Tanure (4): > platform/x86: i2c-multi-instantiate: Rename it for a generic serial > driver name > platform/x86: serial-multi-instantiate: Reorganize I2C functions > ALSA: hda/realtek: Add support for HP Laptops > ACPI / scan: Create platform device for CS35L41 > > Stefan Binding (5): > spi: Make spi_alloc_device and spi_add_device public again > spi: Create helper API to lookup ACPI info for spi device > spi: Support selection of the index of the ACPI Spi Resource before > alloc > spi: Add API to count spi acpi resources > platform/x86: serial-multi-instantiate: Add SPI support > > MAINTAINERS | 4 +- > drivers/acpi/scan.c | 16 +- > drivers/platform/x86/Kconfig | 12 +- > drivers/platform/x86/Makefile | 2 +- > drivers/platform/x86/i2c-multi-instantiate.c | 174 --------- > .../platform/x86/serial-multi-instantiate.c | 349 ++++++++++++++++++ > drivers/spi/spi.c | 137 ++++++- > include/linux/spi/spi.h | 20 + > sound/pci/hda/patch_realtek.c | 43 ++- > 9 files changed, 551 insertions(+), 206 deletions(-) > delete mode 100644 drivers/platform/x86/i2c-multi-instantiate.c > create mode 100644 drivers/platform/x86/serial-multi-instantiate.c >
