On Fri, Jan 28, 2022 at 01:48:44PM +0000, Mark Brown wrote: > On Fri, Jan 28, 2022 at 04:31:47PM +0300, Dan Carpenter wrote: > > On Fri, Jan 28, 2022 at 12:42:04PM +0000, Mark Brown wrote: > > > > This means that the helpers won't support controls that use the top bit > > > of a 32 bit register. > > > Fine, I can delete the checks for negative instead (I'm surprised you > > haven't already received a dozen bot emails about this). > > No, we need the checks for negatives since userspace supplies a signed > value. The check needs to be done on the value in the input structure > before we pull it out for mangling. I probably got bot emails but > frankly these days almost all of them are some combination of barely > legible and misdirected and there's plenty of people who like to fix > these things if they're real. > That's a bit trickier than I initially imagined so I'm going to leave this for smarter people than me... regards, dan carpenter
