At Wed, 16 Apr 2008 13:53:31 +0300, Risto Suominen wrote: > > 2008/4/16, Takashi Iwai <tiwai@xxxxxxx>: > > > > Thanks, that works. But, I get checkpatch errors: > > > > ERROR: do not use assignment in if condition > > #116: FILE: ppc/awacs.c:704: > > > > + if ((err = snd_ctl_add(chip->card, > > > > > > ERROR: do not use assignment in if condition > > #171: FILE: ppc/awacs.c:982: > > > > + if ((err = build_mixers(chip, > > > > > > ERROR: do not use assignment in if condition > > #191: FILE: ppc/awacs.c:999: > > > > + if ((err = build_mixers(chip, > > > > > > > > Please fix? > > > > I can do that but it will make the code much clumsier. Actually, I > think this is checkpatch misunderstanding something. There is a '< 0' > at the end of those conditions. Is it really this kind of assingment > they want to forbid? This is the style there has been all the time. The style "if ((err = xxx) < 0) ..." has been disliked by many people, and now it became to a style to be avoided. This should be simply err = xxx; if (err < 0) ... Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel