On 1/18/22 11:10 AM, Mark Brown wrote: > On Sun, Jan 16, 2022 at 11:15:28PM -0500, Julian Braha wrote: >> When SND_SOC_AMD_YC_MACH is selected, >> and GPIOLIB is not selected, >> Kbuild gives the following warning: >> >> WARNING: unmet direct dependencies detected for SND_SOC_DMIC >> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n] >> Selected by [y]: >> - SND_SOC_AMD_YC_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_ACP6x [=y] > > Why is this a good fix and not removing the dependency on gpiolib from > DMIC? While a DMIC *can* use a GPIO it's not something that's an > intrinsic requirement and it's entirely optional in the code. We also have similar 'depends on GPIOLIB' for Intel boards that are not really useful. see e.g. 4262ddc2ad63 ('ASoC: Intel: boards: add explicit dependency on GPIOLIB when DMIC is used'). IIRC we had this discussion before about doing a larger cleanup.