2008/4/15, Takashi Iwai <tiwai@xxxxxxx>: > > Please split the patch, one to fix the initialization and one to fix > coding styles. > Ok, I will. Sorry, I'm still a beginner at this. > > > @@ -1063,6 +1063,10 @@ static int __init snd_pmac_detect(struct > > else { > > struct pci_dev *pdev = NULL; > > > > +#ifndef for_each_pci_dev > > +#define for_each_pci_dev(d) \ > > + while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL) > > +#endif > > > Why is this needed? > Good question :) I found it necessary on older kernels, it didn't exist. So maybe it should be there only in alsa-driver tree. I believed that it was the same source. Risto _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel