On Wed, Jan 12, 2022 at 10:20:34PM +0800, Mark Brown wrote: >> The devm_regmap_init_mmio() may return error pointer under certain >> circumstances, for example the possible failure of the kzalloc() in >> regmap_mmio_gen_context(), which is called by devm_regmap_init_mmio(). > > This doesn't apply against current code, please check and resend. I checked linux-5.16, and don't think what I said is not against the latest code. The devm_regmap_init_mmio() is defined as devm_regmap_init_mmio_clk() in `include/linux/regmap.h`. And in the same file, the devm_regmap_init_mmio_clk() is defined as __devm_regmap_init_mmio_clk(). Then, __devm_regmap_init_mmio_clk() -> regmap_mmio_gen_context() -> kzalloc(). So I have no idea what's wrong. Maybe I didn't write the commit message clear. Please give me more detail. Sincerely thanks, Jiang
