Re: [PATCH 2/3] ASoC: topology: Allow TLV control to be either read or write

Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx> · Wed, 12 Jan 2022 09:55:55 +0100

On 1/11/2022 5:48 PM, Pierre-Louis Bossart wrote:

On 1/11/22 1:05 PM, Amadeusz Sławiński wrote:
There is no reason to force readwrite access on TLV controls. It can be
either read, write or both. This is further evidenced in code where it
performs following checks:
                 if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_READ) && !sbe->get)
                         return -EINVAL;
                 if ((k->access & SNDRV_CTL_ELEM_ACCESS_TLV_WRITE) && !sbe->put)
                         return -EINVAL;

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx>
Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>

Should there be a Fixes tag

Fixes: 1a3232d2f61d ("ASoC: topology: Add support for TLV bytes controls")

?

I guess it won't hurt, will add and send v2, thanks!