Hi Daniel, My mistake. Thanks for review and comments. I have updated v4 to fix it. Thanks On Wed, 2022-01-05 at 17:53 +0200, Daniel Baluta wrote: > On Mon, Jan 3, 2022 at 1:00 PM YC Hung <yc.hung@xxxxxxxxxxxx> wrote: > > > > From: "YC Hung" <yc.hung@xxxxxxxxxxxx> > > > > This patch adds mt8195 dsp document. The dsp is used for Sound Open > > Firmware driver node. It includes registers, clocks, memory > > regions, > > and mailbox for dsp. > > > > Signed-off-by: yc.hung <yc.hung@xxxxxxxxxxxx> > > The code patch should be created against original source code from > Rob's tree. Here it seems the patch is against v2. > > This isn't going to work! Because when Rob will try to apply the > patch > it will fail since he doesn't have (and doesnt need to have) > your previous versions. > > So, please keep the changes history (that's a good thing!) but always > rebase your patch on maintainer's tree. > > > > --- > > Changes since v2: > > Remove useless watchdog interrupt. > > Add commit message more detail description. > > > > Changes since v1: > > Rename yaml file name as mediatek,mt8195-dsp.yaml > > Refine descriptions for mailbox, memory-region and drop unused > > labels > > in examples. > > --- > > --- > > .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 12 -------- > > ---- > > 1 file changed, 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195- > > dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195- > > dsp.yaml > > index bde763191d86..779daa786739 100644 > > --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195- > > dsp.yaml > > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195- > > dsp.yaml > > @@ -27,14 +27,6 @@ properties: > > - const: cfg > > - const: sram > > > > - interrupts: > > - items: > > - - description: watchdog interrupt > > - > > - interrupt-names: > > - items: > > - - const: wdt > > - > > clocks: > > items: > > - description: mux for audio dsp clock > > @@ -75,8 +67,6 @@ required: > > - compatible > > - reg > > - reg-names > > - - interrupts > > - - interrupt-names > > - clocks > > - clock-names > > - memory-region > > @@ -95,8 +85,6 @@ examples: > > reg = <0x10803000 0x1000>, > > <0x10840000 0x40000>; > > reg-names = "cfg", "sram"; > > - interrupts = <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH 0>; > > - interrupt-names = "wdt"; > > clocks = <&topckgen 10>, //CLK_TOP_ADSP > > <&clk26m>, > > <&topckgen 107>, //CLK_TOP_AUDIO_LOCAL_BUS > > -- > > 2.18.0 > >
