On Wed, Jan 05, 2022 at 02:30:29PM +0000, Mark Brown wrote: > On Wed, Jan 05, 2022 at 11:30:18AM +0000, Charles Keepax wrote: > > > Patches 7,8 specifically will cause some very minor conflicts with > > Lucas's currently outstanding work on the HDA version of cs35l41. > > Whilst things will still build, this patch adds a test key function > > No they won't, an x86 allmodconfig gives this: > > ERROR: modpost: "cs35l41_pm_ops" [sound/soc/codecs/snd-soc-cs35l41-i2c.ko] undefined! > ERROR: modpost: "cs35l41_pm_ops" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined! > ERROR: modpost: "cs35l41_test_key_lock" [sound/soc/codecs/snd-soc-cs35l41.ko] undefined! > ERROR: modpost: "cs35l41_test_key_unlock" [sound/soc/codecs/snd-soc-cs35l41.ko] undefined! Hmm... apologies, let me look into that one. Thanks, Charles