On Wed, Dec 22, 2021 at 11:19:20AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <festevam@xxxxxxx> > > There is no need to keep 'struct gpio_desc *reset_gpio' inside > the private structure becase reset_gpio is only used inside the > probe() function. > > Move it to a local scope. > > Signed-off-by: Fabio Estevam <festevam@xxxxxxx> > --- Patch looks fine, but I do have a slight doubt would it perhaps be better to add a remove function that puts the device back into reset, thus keeping the private member? Feels like it might be a nicer state to leave the chip in if the driver unbinds. Thanks, Charles
