> -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Friday, December 24, 2021 2:27 AM > To: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx> > Cc: alsa-devel@xxxxxxxxxxxxxxxx; vkoul@xxxxxxxxxx; vinod.koul@xxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; tiwai@xxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; > srinivas.kandagatla@xxxxxxxxxx; pierre-louis.bossart@xxxxxxxxxxxxxxx; Kale, > Sanyog R <sanyog.r.kale@xxxxxxxxx>; Liao, Bard <bard.liao@xxxxxxxxx> > Subject: Re: [PATCH 7/7] soundwire: intel: remove PDM support > > On Mon, Dec 13, 2021 at 01:46:34PM +0800, Bard Liao wrote: > > From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > > > > While the hardware supports PDM streams, this capability has never > > been tested or enabled on any product, so this is dead-code. Let's > > remove all this. > > This doesn't build with current code, I'm guessing due to a Soundwire > dependency I don't have: Hi Mark, Sorry, it is my fault. "[PATCH 7/7] soundwire: intel: remove PDM support" was before "[PATCH 4/7] ASoC/SoundWire: dai: expand 'stream' concept beyond". So there was no "intel_pdm_dai_ops" stuff in the "ASoC/SoundWire: dai: expand 'stream' concept beyond" patch. But when I re-order the patches order, the intel_pdm_dai_ops stuff was still in the "ASoC/SoundWire: dai: expand 'stream' concept beyond" patch and I forgot rename set_sdw_stream and get_sdw_stream ops in intel_pdm_dai_ops. I will send v2 to fix it. Sorry about it. > > /mnt/kernel/drivers/soundwire/intel.c:1142:3: error: 'const struct > snd_soc_dai_ops' has no member named 'set_sdw_stream'; did you mean > 'set_stream'? > 1142 | .set_sdw_stream = intel_pdm_set_sdw_stream, > | ^~~~~~~~~~~~~~ > | set_stream > /mnt/kernel/drivers/soundwire/intel.c:1142:20: error: initialization of 'int > (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *, struct > snd_soc_dai *)' from incompatible pointer type 'int (*)(struct snd_soc_dai *, > void *, int)' [-Werror=incompatible-pointer-types] > 1142 | .set_sdw_stream = intel_pdm_set_sdw_stream, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > /mnt/kernel/drivers/soundwire/intel.c:1142:20: note: (near initialization for > 'intel_pdm_dai_ops.hw_params') > /mnt/kernel/drivers/soundwire/intel.c:1143:3: error: 'const struct > snd_soc_dai_ops' has no member named 'get_sdw_stream'; did you mean > 'get_stream'? > 1143 | .get_sdw_stream = intel_get_sdw_stream, > | ^~~~~~~~~~~~~~ > | get_stream > /mnt/kernel/drivers/soundwire/intel.c:1143:20: error: initialization of 'int > (*)(struct snd_pcm_substream *, struct snd_soc_dai *)' from incompatible > pointer type 'void * (*)(struct snd_soc_dai *, int)' [-Werror=incompatible- > pointer-types] > 1143 | .get_sdw_stream = intel_get_sdw_stream, > | ^~~~~~~~~~~~~~~~~~~~ > /mnt/kernel/drivers/soundwire/intel.c:1143:20: note: (near initialization for > 'intel_pdm_dai_ops.hw_free') > cc1: all warnings being treated as errors > make[3]: *** [/mnt/kernel/scripts/Makefile.build:287: > drivers/soundwire/intel.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... > make[2]: *** [/mnt/kernel/scripts/Makefile.build:549: drivers/soundwire] > Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [/mnt/kernel/Makefile:1846: drivers] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [Makefile:219: __sub-make] Error 2
