Re: [PATCH v2 1/3] ASoC: dt-bindings: Use name-prefix schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat 18 Dec 2021 at 15:34, Alexander Stein <alexander.stein@xxxxxxxxxxx> wrote:

> name-prefix.txt does not exist anymore, just reference the schema instead.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxx>

Thanks for doing this.

To keep things coherent, it would be nice if you could do the
same for the other amlogic sound components. They all use prefixes,
except card drivers.

Side note: Any ASoC component could use the sound-name-prefix. Is there
a way express that somehow ? instead of repeating this type of change in
every codec/cpu binding doc ?

> ---
> Changes in v2:
> * Fix 'pass' -> 'true'
>
> .../devicetree/bindings/sound/simple-audio-amplifier.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
> index 26379377a7ac..8327846356d3 100644
> --- a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
> +++ b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
> @@ -9,6 +9,9 @@ title: Simple Audio Amplifier Device Tree Bindings
>  maintainers:
>    - Jerome Brunet <jbrunet@xxxxxxxxxxxx>
>  
> +allOf:
> +  - $ref: name-prefix.yaml#
> +
>  properties:
>    compatible:
>      enum:
> @@ -22,10 +25,7 @@ properties:
>      description: >
>        power supply for the device
>  
> -  sound-name-prefix:
> -    $ref: /schemas/types.yaml#/definitions/string
> -    description: >
> -      See ./name-prefix.txt
> +  sound-name-prefix: true

I've seen a couple of file with this, according the commit description
it solves some kind of name clash but I did not really get how ...

>  
>  required:
>    - compatible




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux