On Fri, Dec 17, 2021 at 02:32:24PM +0100, Cezary Rojewski wrote: > On 2021-12-17 2:02 PM, Mark Brown wrote: > > + for (i = 0; i < snd_ctl_elem_info_get_count(ctl->info); i++) > > + if (!ctl_value_index_valid(ctl, val, i)) > > + valid = false; > Correct me I'm wrong, but it seems a 'return false' would suffice. Is the > continuation of looping still needed once a single check found above > evaluates to true? It doesn't affect the result of the test but it will cause us to print a diagnostic message for each invalid value rather than just the first one we see (eg, if both channels in a stereo control have an invalid value) which seems like it's more helpful to people working with the output than just the first error.
Attachment:
signature.asc
Description: PGP signature
