On 2021-12-17 12:11 AM, Pierre-Louis Bossart wrote:
snd_hdac_ext_stop_streams() has really nothing to do with the extension, it just loops over the bus streams. Move it to the hdac_stream layer and rename to remove the 'ext' prefix and add the precision that the chip will also be stopped. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxx> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx> Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>
Change looks good. I wonder though, if there is a better 'name' for the process (here, stop streams + stop chip as a tear down process) than 'stop_streams_and_chip'.
Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
