kstrdup() can return NULL, it is better to check the return value of it. Signed-off-by: xkernel <xkernel.wang@xxxxxxxxxxx> --- sound/core/jack.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/core/jack.c b/sound/core/jack.c index 32350c6..5fd9954 100644 --- a/sound/core/jack.c +++ b/sound/core/jack.c @@ -509,6 +509,8 @@ int snd_jack_new(struct snd_card *card, const char *id, int type, return -ENOMEM; jack->id = kstrdup(id, GFP_KERNEL); + if (jack->id == NULL) + return -ENOMEM; /* don't creat input device for phantom jack */ if (!phantom_jack) { --