On Mon, Dec 06, 2021 at 11:19:36PM +0000, Kuninori Morimoto wrote: > > Hi Ameer > > >> Probing this driver without adata is strange for me. > >> How did probe this driver ?? > > > > Thank you for your response. Unfortunately, I am not aware of > > implementation details of this component. Coverity suggested that there > > can be a potential NULL pointer access which seems logical to me. Do you > > agree with coverity here? > > I think no potential NULL pointer access, because this driver can't > be called without of_id->data. > But, potential NULL pointer check itself is good idea. > It seems your patch was already accepted :) Yes, indeed. > I noticed that we can replace it to use of_device_get_match_data() > > - const struct of_device_id *of_id = of_match_device(test_of_match, &pdev->dev); > - const struct test_adata *adata = of_id->data; > + const struct test_adata *adata = of_device_get_match_data(&pdev->dev); Thanks, that's a cleaner way. Can you advise how should proceed with this since previous patch is already applied. Should I send a updated version of patch, e.g., v2 or a new patch. > > Best regards > --- > Kuninori Morimoto
