On Fri 03 Dec 03:32 PST 2021, Srinivasa Rao Mandadapu wrote: > From: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx> > > Update bulk clock voting to optional voting as ADSP bypass platform doesn't > need macro and decodec clocks, these are maintained as power domains and > operated from lpass audio core cc. > > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx> > Co-developed-by: Venkata Prasad Potturu <potturu@xxxxxxxxxxxxxx> > Signed-off-by: Venkata Prasad Potturu <potturu@xxxxxxxxxxxxxx> > --- > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > index bcc12f6..c2a1110 100644 > --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > @@ -394,7 +394,7 @@ int lpi_pinctrl_probe(struct platform_device *pdev) > return dev_err_probe(dev, PTR_ERR(pctrl->slew_base), > "Slew resource not provided\n"); > > - ret = devm_clk_bulk_get(dev, MAX_LPI_NUM_CLKS, pctrl->clks); > + ret = devm_clk_bulk_get_optional(dev, MAX_LPI_NUM_CLKS, pctrl->clks); If some platforms requires this clock and others doesn't have one, then please make this statement conditional on the compatible, rather than making it optional on both. Thanks, Bjorn > if (ret) > return dev_err_probe(dev, ret, "Can't get clocks\n"); > > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., > is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. >
