On Thu, 02 Dec 2021 17:02:51 +0100, Werner Sembach wrote: > > Am 02.12.21 um 16:35 schrieb Takashi Iwai: > > On Thu, 02 Dec 2021 16:28:43 +0100, > > Werner Sembach wrote: > >> This fixes the SND_PCI_QUIRK(...) of the TongFang PHxTxX1 barebone. This > >> fixes the issue of sound not working after s3 suspend. > >> > >> When waking up from s3 suspend the Coef 0x10 is set to 0x0220 instead of > >> 0x0020. Setting the value manually makes the sound work again. This patch > >> does this automatically. > >> > >> While being on it, I also fixed the comment formatting of the quirk. > >> > >> Signed-off-by: Werner Sembach <wse@xxxxxxxxxxxxxxxxxxx> > >> Cc: <stable@xxxxxxxxxxxxxxx> > > Please try to put Fixes tag as this is a fix for the existing change. > Sorry, wasn't aware of this. I guess it's [PATCH Fixes] as the beginning of the subject line? No, the Fixes tag is another line you add around your Signed-off-by line for indicating that that the patch is for fixing the given commit. In your case, it'll be like Fixes: dd6dd6e3c791 ("ALSA: hda/realtek: Add quirk for TongFang PHxTxX1") HTH, Takashi