On 30/11/2021 16:17, Mark Brown wrote:
On Tue, Nov 30, 2021 at 04:04:14PM +0000, Srinivas Kandagatla wrote:
msm_routing_put_audio_mixer() can return incorrect value in various scenarios.
Fix this, so that change notifications are sent correctly.
This really isn't a good commit message - I can't tell what the change
is supposed to fix or how it fixes it. Which values in which scenarios
are incorrect in what way?
I agree,
the cases that get incorrect return values are:
scenario 1:
amixer cset iface=MIXER,name='SLIMBUS_0_RX Audio Mixer MultiMedia1' 1
amixer cset iface=MIXER,name='SLIMBUS_0_RX Audio Mixer MultiMedia1' 0
return value is 0 instead of 1
scenario 2:
amixer cset iface=MIXER,name='SLIMBUS_0_RX Audio Mixer MultiMedia1' 1
amixer cset iface=MIXER,name='SLIMBUS_0_RX Audio Mixer MultiMedia1' 1
return value is 1 instead of 0
I will add these details in next spin commit log.
--srini
