Re: 2.6.25-rc8-mm1 -- INFO: possible circular locking dependency detected (while using iw to debug a wireless issue)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Stephen Hemminger <shemminger@xxxxxxxxxx> 2008-04-04 12:11
> The changes in git-net don't look locking related.  I suspect either:
> wireless is calling netlink without holding rtnl_lock;
> or more likely conditional locking ctrl_dumpfamily is confusing lockdep.
> 
> ctrl_dumpfamily only acquires genl_lock if one of the incoming parameters (chains_to_skip)
> is non-zero. Not sure what the design reason is, Thomas could you add a comment?

First call to ctrl_dumpfamily() is coming directly from the message
processing context where genl_lock is already held. Subsequence calls
come from netlink_recvmsg() so we have to take the lock separately.

However, I just noticed the condition should really be
	chains_to_skip != 0 || fams_to_skip != 0
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux