Hi Rob,
On 11/25/21 10:26 PM, Rob Herring wrote:
On Thu, 25 Nov 2021 15:40:50 +0100, Olivier Moysan wrote:
The STM2 I2S DAI can be connected via the audio-graph-card.
Add port entry into the bindings.
Signed-off-by: Olivier Moysan <olivier.moysan@xxxxxxxxxxx>
---
Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++
1 file changed, 5 insertions(+)
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1559750
audio-controller@4000b000: 'port' does not match any of the regexes: '^port@[0-9]', 'pinctrl-[0-9]+'
arch/arm/boot/dts/stm32mp157a-dk1.dt.yaml
arch/arm/boot/dts/stm32mp157c-dk2.dt.yaml
This warning is not a new one.
The i2s2 node in stm32mp15xx-dkx.dtsi would require the following binding:
port:
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
However the spi binding requires to introduce a unit address:
patternProperties:
'^port@[0-9]':
$ref: audio-graph-port.yaml#
unevaluatedProperties: false
The warning can be removed by re-ordering the bindings patches in the
serie, as "additionalProperties: true" makes the check more tolerant on
extra properties.
The patch "ASoC: dt-bindings: stm32: i2s: add audio-graph-card port" can
even be merely dropped.
So, I suggest to resend the serie without audio-graph-card patch.
Does it sound too permissive to you ?
Thanks
Olivier
