On Thu, Nov 18, 2021 at 10:00:34AM +0100, Olivier Moysan wrote:
> ret = snd_soc_add_component(component, NULL, 0);
> - if (ret < 0)
> + if (ret < 0) {
> dev_err(&pdev->dev, "%s: Failed to register PCM platform\n",
> __func__);
> + return ret;
> + }
>
> - return ret;
> + pm_runtime_enable(&pdev->dev);
Enabling runtime PM after registering the component may potentially lead
to a race where something manages to go in and starts using the device
including what should be runtime PM stuff. That'd lead to a reference
not being taken that should be. It's unlikely to actually happen but
it's better to be safe.
Attachment:
signature.asc
Description: PGP signature
