On Fri, Oct 29, 2021 at 08:38:54PM +0530, Sameer Pujar wrote: > On 10/26/2021 11:53 AM, Sameer Pujar wrote: > > On 10/25/2021 6:28 PM, Jaroslav Kysela wrote: > > > It's a bit unrelated comment to this change, but it may be worth to > > > verify all > > > kcontrol put callbacks in the tegra code. Ensure that value 1 is > > > returned only > > > when something was really changed in hardware. > There are cases when the mixer control update is not immediately written to > HW, instead the update is ACKed (stored in variable) and writen to HW at a > later point of time. Do these cases qualify for "return 1" as well? What matters is the user visible effect. It doesn't matter when the change gets written to the hardware, the important thing is that an applicaton will read back a new value and users will observe whatver change the control change caused.
Attachment:
signature.asc
Description: PGP signature
