Quoting Srinivasa Rao Mandadapu (2021-10-27 00:47:52) > > On 10/7/2021 11:29 PM, Stephen Boyd wrote: > > Quoting Srinivasa Rao Mandadapu (2021-10-07 06:48:38) > >> Add device tree binding compatible name for Qualcomm SC7280 LPASS LPI pinctrl driver. > >> > >> Signed-off-by: Venkata Prasad Potturu <potturu@xxxxxxxxxxxxxx> > >> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@xxxxxxxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > >> index e47ebf9..578b283 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-pinctrl.yaml > >> @@ -16,7 +16,9 @@ description: | > >> > >> properties: > >> compatible: > >> - const: qcom,sm8250-lpass-lpi-pinctrl > >> + enum: > >> + - qcom,sc7280-lpass-lpi-pinctrl > >> + - qcom,sm8250-lpass-lpi-pinctrl > > I suspect we need to split the binding because the function list needs > > to change. Can you make a whole new file that's probably largely a copy > > of this file and/or extract the common bits into a meta schema and > > include that in both the files? Then the function list can be different > > and the clock property can be omitted in the sc7280 file. > > As most are common functions and fixed number of LPASS Lpi pin > configuration across platforms, > > Only diff is ADSP bypass platforms 2 clocks are optional. Otherwise > clock design also same for SC7280 and SM8250 based architecture. > > So I feel Keeping common file is better for now. I don't agree. We want to be very strict about what is exposed. It needs to match exactly what is supported on the SoC, not be a superset of it.
