On 10/28/21 12:18 AM, Julian Braha wrote: > When SND_SOC_AMD_RENOIR_MACH or SND_SOC_AMD_RV_RT5682_MACH > are selected, and GPIOLIB is not selected, Kbuild gives > the following warnings, respectively: > > WARNING: unmet direct dependencies detected for SND_SOC_DMIC > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n] > Selected by [y]: > - SND_SOC_AMD_RENOIR_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_RENOIR [=y] > > and > > WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A > Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n] > Selected by [y]: > - SND_SOC_AMD_RV_RT5682_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_ACP3x [=y] && I2C [=y] && CROS_EC [=y] > > This is because SND_SOC_DMIC and SND_SOC_MAX98357A are > selected by SND_SOC_AMD_RV_RT5682_MACH and SND_SOC_AMD_RENOIR_MACH, > respectively. However, neither of the selectors depend on or select GPIOLIB, > despite their selectees depending on GPIOLIB. > > These unmet dependency bugs were detected by Kismet, > a static analysis tool for Kconfig. Please advise if this > is not the appropriate solution. > > Signed-off-by: Julian Braha <julianbraha@xxxxxxxxx> > --- > sound/soc/amd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig > index 56e7c079deac..2c6af3f8f296 100644 > --- a/sound/soc/amd/Kconfig > +++ b/sound/soc/amd/Kconfig > @@ -38,7 +38,7 @@ config SND_SOC_AMD_RV_RT5682_MACH > select I2C_CROS_EC_TUNNEL > select SND_SOC_RT1015 > select SND_SOC_RT1015P > - depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC > + depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC && GPIOLIB > help > This option enables machine driver for RT5682 and MAX9835. > > @@ -51,7 +51,7 @@ config SND_SOC_AMD_RENOIR > config SND_SOC_AMD_RENOIR_MACH > tristate "AMD Renoir support for DMIC" > select SND_SOC_DMIC > - depends on SND_SOC_AMD_RENOIR > + depends on SND_SOC_AMD_RENOIR && GPIOLIB For Renoir platform, DMIC driver selected for registering codec dai with ASOC. No additional functionality handled related to GPIO. Do you still see necessity adding GPIOLIB dependency? > help > This option enables machine driver for DMIC > > -- > 2.30.2 >
