typo in commit subject: coponment -> component please use scripts/checkpatch.pl --strict --codespell On 10/26/21 9:51 PM, David Lin wrote: > Use set_jack ops to set jack for new machine drivers. Meanwhile, > the old machine drivers can still call previous export function > "nau8825_enable_jack_detect". > > Co-developed-by: Mac Chiang <mac.chiang@xxxxxxxxx> > Signed-off-by: Mac Chiang <mac.chiang@xxxxxxxxx> > Signed-off-by: David Lin <CTLIN0@xxxxxxxxxxx> > --- > sound/soc/codecs/nau8825.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c > index 67de0e49ccf4..c845f19b7c41 100644 > --- a/sound/soc/codecs/nau8825.c > +++ b/sound/soc/codecs/nau8825.c > @@ -2416,6 +2416,12 @@ static int __maybe_unused nau8825_resume(struct snd_soc_component *component) > return 0; > } > > +static int nau8825_set_jack(struct snd_soc_component *component, > + struct snd_soc_jack *jack, void *data) > +{ > + return nau8825_enable_jack_detect(component, jack); > +} > + in some cases, this function can be called with a NULL jack argument. See other codec drivers, e.g. int arizona_jack_set_jack(struct snd_soc_component *component, struct snd_soc_jack *jack, void *data) { struct arizona_priv *info = snd_soc_component_get_drvdata(component); if (jack) return arizona_jack_enable_jack_detect(info, jack); else return arizona_jack_disable_jack_detect(info); }