Re: [PATCH 1/3] ASoC: nau8825: add set_jack coponment support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/26/21 4:38 AM, David Lin wrote:
> Use set_jack ops to set jack for new machine drivers. Meanwhile,
> the old machine drivers can still call previous export function
> "nau8825_enable_jack_detect".
> 
> Co-Developed-by: Mac Chiang <mac.chiang@xxxxxxxxx>

if you use the Co-developed-by: tag (no capital letter after 'C'), you
still need to provide your Signed-off-by: tag

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

same comment for the 2 other patches in this series.

> Signed-off-by: David Lin <CTLIN0@xxxxxxxxxxx>
> ---
>  sound/soc/codecs/nau8825.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/codecs/nau8825.c b/sound/soc/codecs/nau8825.c
> index 67de0e49ccf4..c845f19b7c41 100644
> --- a/sound/soc/codecs/nau8825.c
> +++ b/sound/soc/codecs/nau8825.c
> @@ -2416,6 +2416,12 @@ static int __maybe_unused nau8825_resume(struct snd_soc_component *component)
>  	return 0;
>  }
>  
> +static int nau8825_set_jack(struct snd_soc_component *component,
> +			    struct snd_soc_jack *jack, void *data)
> +{
> +	return nau8825_enable_jack_detect(component, jack);
> +}
> +
>  static const struct snd_soc_component_driver nau8825_component_driver = {
>  	.probe			= nau8825_component_probe,
>  	.remove			= nau8825_component_remove,
> @@ -2430,6 +2436,7 @@ static const struct snd_soc_component_driver nau8825_component_driver = {
>  	.num_dapm_widgets	= ARRAY_SIZE(nau8825_dapm_widgets),
>  	.dapm_routes		= nau8825_dapm_routes,
>  	.num_dapm_routes	= ARRAY_SIZE(nau8825_dapm_routes),
> +	.set_jack		= nau8825_set_jack,
>  	.suspend_bias_off	= 1,
>  	.idle_bias_on		= 1,
>  	.use_pmdown_time	= 1,
> 



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux