Re: [PATCH 2/2] ASoC: codec: tlv320adc3xxx: New codec driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 25 Oct 2021, Mark Brown wrote:

> On Mon, Oct 25, 2021 at 06:01:04PM +0200, Ricard Wanderlof wrote:
> 
> > I'll add it to the DT configuration, but I can't really see why the having 
> > an additional runtime control would be a lot of extra work.
> 
> > In a completely embedded system where the microphone is part of the 
> > internal design it makes sense not to have it controllable of course, but 
> > in a system where the microphone is an external component (i.e. plugged 
> > into a microphone connector), the system design might need for it to be 
> > user configurable.
> 
> In any design we really ought to have some explicit confirmation before
> we allow users to go randomly changing voltages, it may cause damage if
> someone gets it wrong.  This means that the feature really ought to be
> an opt in one if it's going to be there.

Good point. 

So like a module parameter, or perhaps governed something in sysfs?

/Ricard
-- 
Ricard Wolf Wanderlof                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux