Re: [PATCH v2 0/4] ALSA: hda: New NHLT functions and cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/18/21 9:40 AM, Cezary Rojewski wrote:
> Changes add two crucial functions: endpoint presence-check and
> retrieval of endpoint's BLOB (hardware configuration) to NHLT API.
> 
> Few cleanups accompany the above:
> Work is done to align NHLT-struct naming with other, commonly used
> ACPI-structs. While cleaning up, don't forget about "is DMIC in NHLT?"
> check. No need to check for channel count or anything DMIC-configuration
> related, just straight up verify link_type presence.
> 
> Changes in v2:
> - patch "ALSA hda: Drop device-argument in NHLT functions" has been
>   dropped
> - updated newly added declarations in intel-nhlt.h so warning:
>   "no-previous-prototype-for-function" and error:
>   "use-of-undeclared-identifier" are no longer observed when
>   CONFIG_SND_INTEL_NHLT is not enabled
> - added Mark's tag to the last patch of the series
> 
> Amadeusz Sławiński (4):
>   ALSA: hda: Follow ACPI convention in NHLT struct naming
>   ALSA: hda: Fill gaps in NHLT endpoint-interface
>   ALSA: hda: Simplify DMIC-in-NHLT check
>   ASoC: Intel: Skylake: Use NHLT API to search for blob

Our tests don't show any regressions:
https://sof-ci.01.org/linuxpr/PR3218/build6579/devicetest/

and the code looks fine

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux