Hi,
On Mon, Oct 18, 2021 at 01:40:35PM +0200, Takashi Iwai wrote:
> UAPI header should have no C++ style comment but only in the
> traditional C style comment, but there is still one place we used it
> mistakenly. This patch corrects it.
>
> Fixes: 542283566679 ("ALSA: ctl: remove unused macro for timestamping of elem_value")
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> ---
> include/uapi/sound/asound.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
When adding code comment into UAPI, I'll take enough care of its style...
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index 5859ca0a1439..5fbb79e30819 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -1002,7 +1002,7 @@ typedef int __bitwise snd_ctl_elem_iface_t;
> #define SNDRV_CTL_ELEM_ACCESS_WRITE (1<<1)
> #define SNDRV_CTL_ELEM_ACCESS_READWRITE (SNDRV_CTL_ELEM_ACCESS_READ|SNDRV_CTL_ELEM_ACCESS_WRITE)
> #define SNDRV_CTL_ELEM_ACCESS_VOLATILE (1<<2) /* control value may be changed without a notification */
> -// (1 << 3) is unused.
> +/* (1 << 3) is unused. */
> #define SNDRV_CTL_ELEM_ACCESS_TLV_READ (1<<4) /* TLV read is possible */
> #define SNDRV_CTL_ELEM_ACCESS_TLV_WRITE (1<<5) /* TLV write is possible */
> #define SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE (SNDRV_CTL_ELEM_ACCESS_TLV_READ|SNDRV_CTL_ELEM_ACCESS_TLV_WRITE)
> --
> 2.26.2
Thanks
Takashi Sakamoto
