Re: [PATCH] ASoC: soc-component: improve error reporting for register access

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 14, 2021 at 11:31:24AM -0500, Pierre-Louis Bossart wrote:

> BTW while looking at the code, I started to wonder if it's intentional
> that we cannot check any error code on component->driver->read(). We do
> for the write and on regmap read, which suggests this API is problematic?

I dunno about intentional but it's always been that way since ASoC was
originally merged, it's just that nobody's ever changed that as part of
one of the refactorings.  I did add error checking to the regmap read
interface when I wrote that but I wasn't about to go fixing up all the
ASoC drivers for a new API.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux