Re: [PATCH v3] ASoC: rt1011: Fix 'I2S Reference' enum control caused error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 13/10/2021 14:52, Mark Brown wrote:
> On Tue, Oct 12, 2021 at 02:52:11PM +0300, Péter Ujfalusi wrote:
>> On 12/10/2021 14:45, Mark Brown wrote:
> 
>>> [1/1] ASoC: rt1011: Fix 'I2S Reference' enum control caused error
>>>       commit: c3de683c4d1d68ff27f21606b921d92ffdea3352
> 
>> I have noted that this patch is not enough to fix the i2s reference
>> support and a complete patch has been already sent:
> 
>> https://lore.kernel.org/alsa-devel/20211012063113.3754-1-peter.ujfalusi@xxxxxxxxxxxxxxx/
> 
> Are you sure this isn't just b4 thinking your later version matches the
> earlier version when it's the later version that got applied (you'll
> have got multiple mails with one for the later version as well)?

linux-next has this v3 and not the the proper fix sent a bit later

>> What keyword should I use next time to 'block' a patch applied?
> 
> You can't, there's a gap between me queueing things and testing and
> pushing out and mail sent in that time might not get seen.
> 
> You should also take care that when you're sending things you're doing
> so in a standard fashion, occasionally I have seen people bury things in
> the middle of threads or whatever which causes b4 to think an earlier
> version is actually a later one.

I don't send patches as reply but in this particular case I did changed
the commit subject since the original commit adding the i2s reference
selection was mostly broken.

I can send an updated patch on top of next, but the one we have applied
only fixes the alsamixer crash, the code remains broken.

-- 
Péter



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux