Hi Jaroslav,
Dne 05. 10. 21 v 10:58 Jaroslav Kysela napsal(a):
On 04. 10. 21 16:32, Pavel Hofman wrote:
+static int openctl_play_rateshift(struct loopback_handle *lhandle,
+ char *ascii_name) {
I would create 'openctl_elem_ascii' function which will accept the ascii
id and the snd_ctl_elem_value_t pointer like 'openctl_elem' does. The
the common code may be moved to the 'openctl_elem_id' function from the
'openctl_elem' function.
But it's just nitpicking, the rest of patch looks fine and follows my
suggestion. Thank you.
Thanks for your recommendations. I sent the v2 patch in
https://patchwork.kernel.org/project/alsa-devel/patch/20211005194903.7957-1-pavel.hofman@xxxxxxxxxxx/
. Please is it OK now or should I make some more changes?
Thanks a lot,
Pavel.
