On 10/11/21 11:19 PM, Mark Brown wrote: > On Tue, Oct 12, 2021 at 12:17:01AM +0530, Vijendar Mukunda wrote: > >> pdevinfo[2].res = &adata->res[2]; >> >> + pdevinfo[3].name = "acp5x_nu8821_cs35l41_mach"; >> + pdevinfo[3].id = 0; >> + pdevinfo[3].parent = &pci->dev; > > This appears to unconditionally assume that any machine with this > hardware is going to have exactly the same CODEC/amp combination - that > seems like it's going to go badly at some point. Shouldn't there be > some other check that we're instantiating the right machine driver? > we will make the platform device as generic one something like "acp5x_mach". Currently we have only one target platform with above codec combinations for this APU series. When we get new codecs combinations to support, we will address it in machine driver by adding DMI checks for distinguishing codec combinations. > BTW your clock appears to be set quite a way into the future (possibly > about 24 hours?) which is confusing things. > Will fix the system time settings.
