>> We'd need to Hans to comment on this since he's really the only one >> maintaining this code. > > So as Mark wrote in his later reply: > > "AIUI with the clock API the idiomatic thing is that any optionality is > handled at the point where the clock is acquired - if the clock is > optional you end up with NULL which in the clock API is a dummy clock > and ignored. The rest of the code then doesn't need to worry about any > of this stuff and the handling can only be in one place." > > Combined with there pretty much always actually being an mclk I believe > that this patch from Andy results in a nice cleanup so I'm in favor with > this. And the other cleanups also look sensible to me No sustained objection on my side. Thanks Andy for starting this thread.