On 9/28/21 10:10 AM, Mark Brown wrote: > On Tue, Sep 28, 2021 at 11:22:48AM +0300, Peter Ujfalusi wrote: >> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> >> >> The work-around enabled in hda-stream.c is only required on earlier >> versions of SOCs/PCH (Skylake, KabyLake, ApolloLake, >> GeminiLake). Before setting the format on the host DMA, it is required >> to couple the host and link DMA - which as a consequence shall use the >> same format. > > This breaks the build for me: > > /mnt/kernel/sound/soc/sof/intel/hda-stream.c: In function 'hda_dsp_stream_hw_params': > /mnt/kernel/sound/soc/sof/intel/hda-stream.c:436:42: error: implicit declaration of function 'get_chip_info'; did you mean 'get_group_info'? [-Werror=implicit-function-declaration] Ack, we're missing a dependency. Peter, this function was moved to shim.h with Ranjani's patch "ASoC: SOF: Intel: hda: expose get_chip_info()" That patch was added in the SOF multi-core series.
