Hi, On 9/28/21 10:15 PM, Dmitry Osipenko wrote: > 18.07.2021 20:57, Hans de Goede пишет: >> Commit 446d0a71b47f ("codecs/rt5640: Move out BayTrail-specific pin switches") >> moved the setting of the 'Headphone Switch' / 'Headset Mic Switch' into >> "If.hp" resp "If.hsmic" blocks. But instead of making them part of the >> True {} block inside that If, the statements where added add the top-level >> of the If {} block where they are no-ops. >> >> Move them to inside the True blocks so that these Switches again get >> properly turned on/off. This fixes the Headphones and Headset-mic no longer >> working on bytcr-rt5640 devices. >> >> Cc: Dmitry Osipenko <digetx@xxxxxxxxx> >> Fixes: 446d0a71b47f ("codecs/rt5640: Move out BayTrail-specific pin switches") >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> ucm2/bytcr-rt5640/HiFi.conf | 36 ++++++++++++++++++++---------------- >> 1 file changed, 20 insertions(+), 16 deletions(-) > > Hi, > > I don't see this patch in upstream alsa-ucm, is it still actual? Yes this patch series is still actual. I also have 3 other patches pending where I was waiting for the mathcing kernel parts to land first. Those have landed now, so I'll send out those now too, including a resend of these 2. Regards, Hans