On Fri, Sep 3, 2021 at 11:36 AM Sameer Pujar <spujar@xxxxxxxxxx> wrote: > > Use schema reference for 'sound-name-prefix' property wherever > necessary. > > Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx> > Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > Cc: Stephan Gerhold <stephan@xxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Reviewed-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > --- [...] > diff --git a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > index ffb8fcf..68e5ad2 100644 > --- a/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > +++ b/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml > @@ -9,6 +9,9 @@ title: NXP/Goodix TFA989X (TFA1) Audio Amplifiers > maintainers: > - Stephan Gerhold <stephan@xxxxxxxxxxx> > > +allOf: > + - $ref: name-prefix.yaml# > + > properties: > compatible: > enum: > @@ -21,12 +24,6 @@ properties: > '#sound-dai-cells': > const: 0 > > - sound-name-prefix: You can't remove the property. This is now a warning in linux-next: Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml: audio-codec@34: 'sound-name-prefix' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml Documentation/devicetree/bindings/sound/nxp,tfa989x.example.dt.yaml: audio-codec@36: 'sound-name-prefix' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml Just 'sound-name-prefix: true' is fine > - $ref: /schemas/types.yaml#/definitions/string > - description: > - Used as prefix for sink/source names of the component. Must be a > - unique string among multiple instances of the same component. > - > vddd-supply: > description: regulator phandle for the VDDD power supply. > > diff --git a/Documentation/devicetree/bindings/sound/rt5659.txt b/Documentation/devicetree/bindings/sound/rt5659.txt > index c473df5..013f534 100644 > --- a/Documentation/devicetree/bindings/sound/rt5659.txt > +++ b/Documentation/devicetree/bindings/sound/rt5659.txt > @@ -42,7 +42,7 @@ Optional properties: > - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin. > - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin. > > -- sound-name-prefix: Please refer to name-prefix.txt > +- sound-name-prefix: Please refer to name-prefix.yaml > > - ports: A Codec may have a single or multiple I2S interfaces. These > interfaces on Codec side can be described under 'ports' or 'port'. > diff --git a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml > index 5986d1f..c597d9d 100644 > --- a/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml > +++ b/Documentation/devicetree/bindings/sound/simple-audio-mux.yaml > @@ -13,6 +13,9 @@ description: | > Simple audio multiplexers are driven using gpios, allowing to select which of > their input line is connected to the output line. > > +allOf: > + - $ref: name-prefix.yaml# > + > properties: > compatible: > const: simple-audio-mux > @@ -21,12 +24,6 @@ properties: > description: | > GPIOs used to select the input line. > > - sound-name-prefix: Here too, but I guess we don't have any example to throw a warning?
