Hi, The direct use of 'bar' as address regions in SOF can limit portability and makes assumption that all platforms are using memory mapped regions or BARs to communicate with the DSP. The core API should not use 'bar' in it's parameter lists or make assumption that the platform needs to comply with this system integration. Use the region type as an ID in core and translate that in platform dependent code to a way to access registers, mailbox or DSP memory. Regards, Peter --- Peter Ujfalusi (12): ASoC: SOF: Intel: bdw: Set the mailbox offset directly in bdw_probe ASoC: SOF: ipc: Remove snd_sof_dsp_mailbox_init() ASoC: SOF: imx: Do not initialize the snd_sof_dsp_ops.read64 ASoC: SOF: imx: imx8: Bar index is only valid for IRAM and SRAM types ASoC: SOF: imx: imx8m: Bar index is only valid for IRAM and SRAM types ASoC: SOF: loader: No need to export snd_sof_fw_parse_ext_data() ASoC: SOF: core: Do not use 'bar' as parameter for block_read/write ASoC: SOF: debug: Add generic API and ops for DSP regions ASoC: SOF: imx: Provide debugfs_add_region_item ops for core ASoC: SOF: Intel: Provide debugfs_add_region_item ops for core ASoC: SOF: loader: Use the generic ops for region debugfs handling ASoC: SOF: debug: No need to export the snd_sof_debugfs_io_item() sound/soc/sof/debug.c | 24 ++++-- sound/soc/sof/imx/imx8.c | 17 +++-- sound/soc/sof/imx/imx8m.c | 13 +++- sound/soc/sof/intel/apl.c | 1 + sound/soc/sof/intel/bdw.c | 5 +- sound/soc/sof/intel/byt.c | 2 + sound/soc/sof/intel/cnl.c | 1 + sound/soc/sof/intel/icl.c | 1 + sound/soc/sof/intel/pci-tng.c | 1 + sound/soc/sof/intel/tgl.c | 1 + sound/soc/sof/ipc.c | 34 +++------ sound/soc/sof/loader.c | 137 +++++++++++++++------------------- sound/soc/sof/ops.h | 25 +++++-- sound/soc/sof/sof-priv.h | 55 +++++++------- sound/soc/sof/utils.c | 28 +++++-- 15 files changed, 187 insertions(+), 158 deletions(-) -- 2.33.0
