> -----Original Message----- > From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > Sent: Wednesday, September 8, 2021 11:23 PM > To: Jack Yu <jack.yu@xxxxxxxxxxx>; broonie@xxxxxxxxxx; > lgirdwood@xxxxxxxxx > Cc: Oder Chiou <oder_chiou@xxxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; > lars@xxxxxxxxxx; kent_chen@xxxxxxxxxxx [陳建宏] > <kent_chen@xxxxxxxxxxx>; Derek [方德義] <derek.fang@xxxxxxxxxxx>; > Shuming [范書銘] <shumingf@xxxxxxxxxxx>; Flove(HsinFu) > <flove@xxxxxxxxxxx> > Subject: Re: [PATCH] ASoC: rt1011: add i2s reference control for rt1011 > > On 9/7/21 9:17 PM, Jack Yu wrote: > > > >> -----Original Message----- > >> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > >> Sent: Tuesday, September 7, 2021 10:54 PM > >> To: Jack Yu <jack.yu@xxxxxxxxxxx>; broonie@xxxxxxxxxx; > >> lgirdwood@xxxxxxxxx > >> Cc: Oder Chiou <oder_chiou@xxxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; > >> lars@xxxxxxxxxx; kent_chen@xxxxxxxxxxx [陳建宏] > >> <kent_chen@xxxxxxxxxxx>; Derek [方德義] <derek.fang@xxxxxxxxxxx>; > >> Shuming [范書銘] <shumingf@xxxxxxxxxxx>; Flove(HsinFu) > >> <flove@xxxxxxxxxxx> > >> Subject: Re: [PATCH] ASoC: rt1011: add i2s reference control for > >> rt1011 > >> > >> On 9/6/21 5:12 AM, Jack Yu wrote: > >>> Add i2s reference control for rt1011 amp. > >>> > >>> Signed-off-by: Jack Yu <jack.yu@xxxxxxxxxxx> > >> > >>> +static const char * const rt1011_i2s_ref[] = { > >>> + "None", "Left Channel", "Right Channel" > >>> +}; > >> > >>> +enum { > >>> + RT1011_I2S_REF_NONE, > >>> + RT1011_I2S_REF_LEFT_CH, > >>> + RT1011_I2S_REF_RIGHT_CH, > >>> +}; > >> > >> is it possible to get Left-Right-mix (mixed on rt1011) and Left-Right > >> (two channels, with the application selecting what they want)? > > > > It's a mono amp, so there's no Left-Right-mix setting. > > And for the choice of Left-Right channel, it's already available with this > patch. > > So it's just to place a mono reference in either left or right channel of the I2S > link? Why not dual-mono as well then? The patch is a specific control for two amps to send AEC data on single I2S data input pin by standard I2S protocol. If there are two I2S input from SoC, we can add dual-mono mode for it, but so far there is no requirement regarding to this mode. > ------Please consider the environment before printing this e-mail.