Re: [PATCH v5 15/21] ASoC: qdsp6: audioreach: add q6apm support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 07/09/2021 16:04, Pierre-Louis Bossart wrote:

+    graph->graph = audioreach_alloc_graph_pkt(apm, &info->sg_list,
graph_id);
+    if (IS_ERR(graph->graph)) {
+        kfree(graph);
+        return ERR_PTR(-ENOMEM);
+    }
+
+    spin_lock(&apm->lock);
+    idr_alloc(&apm->graph_idr, graph, graph_id,
+          graph_id + 1, GFP_ATOMIC);

does this need to be ATOMIC?

We are inside spinlock.

but this is not used in an interrupt handler or anything that isn't in a
process context, is it?

No, it is in process context only.

--srini



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux