Re: [PATCH 2/3] ASoC: Use schema reference for sound-name-prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 1, 2021 at 11:19 AM Sameer Pujar <spujar@xxxxxxxxxx> wrote:
>
> Use schema reference for 'sound-name-prefix' property wherever
> necessary.
>
> Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
> Cc: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> Cc: Stephan Gerhold <stephan@xxxxxxxxxxx>
> Cc: bardliao@xxxxxxxxxxx
> Cc: Alexandre Belloni <aleandre.belloni@xxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml | 7 +------
>  Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml | 7 +------
>  Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml  | 7 +------
>  Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml          | 5 +----
>  Documentation/devicetree/bindings/sound/rt5659.txt                | 2 +-
>  Documentation/devicetree/bindings/sound/simple-audio-mux.yaml     | 5 +----
>  6 files changed, 6 insertions(+), 27 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> index 5f6b37c..ae04a11 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
> @@ -48,12 +48,7 @@ properties:
>
>    sound-name-prefix:
>      pattern: "^DSPK[1-9]$"
> -    $ref: /schemas/types.yaml#/definitions/string
> -    description:
> -      Used as prefix for sink/source names of the component. Must be a
> -      unique string among multiple instances of the same component.
> -      The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> -      available instances on a Tegra SoC.
> +    $ref: "name-prefix.yaml#/properties/sound-name-prefix"

This is generally not how we reference common properties.

Either you add a $ref to the whole schema document at the top level of
this one or add a 'select: true' in name-prefix.yaml.

Rob



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux